Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to disable module pattern components #18133

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add a flag to disable module pattern components #18133

merged 1 commit into from
Mar 6, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 26, 2020

This was already very niche and the warning doesn't fire on WWW. Let's disable these completely in the modern WWW build and stop doing these three checks for every element returned from a function?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 26, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae4f0b2:

Sandbox Source
laughing-sara-x404g Configuration

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 26, 2020

We can probably even hard-break in both WWW builds.

@sizebot
Copy link

sizebot commented Feb 26, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against ae4f0b2

@sizebot
Copy link

sizebot commented Feb 26, 2020

Details of bundled changes.

Comparing: 60016c4...ae4f0b2

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.7 KB 123.7 KB 38.58 KB 38.58 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.61 KB 3.61 KB 1.37 KB 1.37 KB UMD_DEV
ReactDOM-dev.js -0.3% -0.2% 894.37 KB 892.12 KB 199.61 KB 199.24 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 708 B 706 B UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.69 KB 53.69 KB 14.01 KB 14.01 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.25 KB 121.25 KB 38.11 KB 38.11 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 138.16 KB 138.16 KB 35.19 KB 35.19 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.22 KB 11.22 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 49.52 KB 49.52 KB 13.55 KB 13.55 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 127.45 KB 127.45 KB 33.83 KB 33.83 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.36 KB 20.36 KB 7.45 KB 7.45 KB NODE_PROD
react-dom.development.js 0.0% -0.0% 914.29 KB 914.29 KB 200.19 KB 200.19 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.08 KB 59.08 KB 14.75 KB 14.75 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.75 KB 119.75 KB 38.22 KB 38.22 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.28 KB 10.28 KB 3.49 KB 3.49 KB UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 134.46 KB 134.46 KB 34.28 KB 34.28 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 123.4 KB 123.4 KB 39.38 KB 39.38 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 866.69 KB 866.69 KB 196.52 KB 196.52 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 56.05 KB 56.05 KB 14.54 KB 14.54 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.94 KB 3.94 KB 1.46 KB 1.46 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.9 KB 119.9 KB 37.45 KB 37.45 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10 KB 10 KB 3.39 KB 3.38 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.19 KB 1.19 KB 685 B 683 B NODE_PROD
ReactDOM-prod.js -0.5% -0.3% 370.74 KB 369.06 KB 67.45 KB 67.25 KB FB_WWW_PROD
ReactDOM-profiling.js -0.4% -0.3% 381.95 KB 380.27 KB 69.57 KB 69.35 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.21 KB 3.21 KB 1.3 KB 1.3 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.03 KB 1.03 KB 629 B 628 B NODE_PROD
react-dom-testing.development.js 0.0% -0.0% 887.91 KB 887.91 KB 195.74 KB 195.74 KB UMD_DEV
react-dom-testing.production.min.js 0.0% -0.0% 117.41 KB 117.41 KB 37.72 KB 37.72 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% -0.0% 869.57 KB 869.57 KB 194.5 KB 194.5 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 120.94 KB 120.94 KB 38.9 KB 38.89 KB UMD_PROFILING
react-dom-testing.development.js 0.0% -0.0% 841.37 KB 841.37 KB 192.18 KB 192.18 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 128.57 KB 128.57 KB 34.05 KB 34.05 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.77 KB 20.77 KB 7.6 KB 7.6 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -0.4% -0.3% 539.01 KB 536.76 KB 112.86 KB 112.5 KB FB_WWW_DEV
react-art.development.js 0.0% -0.0% 636.01 KB 636.01 KB 133.68 KB 133.68 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 106.49 KB 106.49 KB 32.15 KB 32.14 KB UMD_PROD
react-art.development.js 0.0% -0.0% 536.49 KB 536.49 KB 114.99 KB 114.99 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 71.42 KB 71.42 KB 21.36 KB 21.36 KB NODE_PROD
ReactART-prod.js -0.7% -0.5% 227.26 KB 225.59 KB 38.5 KB 38.3 KB FB_WWW_PROD

ReactDOM: size: 0.0%, gzip: -0.3%

Size changes (experimental)

Generated by 🚫 dangerJS against ae4f0b2

@gaearon gaearon merged commit 562cf01 into facebook:master Mar 6, 2020
@gaearon gaearon deleted the add-indet-flag branch March 6, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @sebmarkbage @facebook-github-bot